Mingyi Kang

> This looks like a smart little optimization. Have you done any benchmark to see if GETSET gets any faster or uses less CPU? The redis-benchmark did not test the...

> Regarding your benchmark, there is a risk Redis is faster than the benchmark script. You can check `top` to see if the benchmark script is the bottleneck. You can...

> Optimization and code to support it looks good to me, however other than the optimization this change also affects: > > 1. key hit and key miss statistics. the...

If `getset` aims for writing and does not affect the hits/misses stats (same as `incr` command), then we can remove those many modifications which aim to keep the stats. The...

Nothing was missed, you are right, I misunderstood and thought that we need to keep the original behavior. If it is better to consider getset as a write command, then...

Ok, wait for more feedback first.