Jerry Tao

Results 8 comments of Jerry Tao

`fp,ok:=s.MediaDescriptions[0].Attribute("fingerprint")`

@enobufs You are right, I made a mistake in my test code. So the only change should be: - If received reconfigs with outgoingReset, clear sending pending buffer.

Yes, I agree with you that OutgoingReset should only mean shutdown() rather than close. But in the official lib, the usrsctp does not buffer anything, the SctpTransport only buffer one...

Here are my thoughts, - The outgoingReset happened in sctp.Stream level, so they could and should keep sending the data until it has no data to send. - The data...

How about moving cache and close logic to datachannel? In fact, when we talk about close we are talking about data channel close, the sctp rfc didn't define stream close...

@enobufs I have tried to implement the discard logic as you say, [A](https://github.com/jerry-tao/sctp/tree/wip), [B](https://github.com/jerry-tao/sctp/tree/wip-2). - A: Discard the pending buffer when it popped. - B: Move the buffer from association...

I have created PR #245 and #246 . I prefer Plan A too, small change, easy to implement. After finishing this we could add buffer to datachannel first. I will...

I think the problem is [stun_conn.go#L68](https://github.com/pion/turn/blob/master/stun_conn.go#L68), if the frame size is larger than MTU, it will panic. I think change it to: ``` if errors.Is(err, errInvalidTURNFrame) { return 0, nil,...