roryqi comments

Results 437 comments of


                                            roryqi

[#6133] Improvement(core): Supports get Fileset schema location in the AuthorizationUtils

@Abyss-lord Would you like to continue this PR?

[#6133] Improvement(core): Supports get Fileset schema location in the AuthorizationUtils

After discussing offline, I will take on this PR.

[#6632] improvement(core): Add timestamp information to metrics

@FANNG1 Would you like to take an another look? If no another suggestion, I will merge this PR tomorrow.

[#6632] improvement(core): Add timestamp information to metrics

> > This PR adds extra metrics name to current guaga metrics like adding `gravitino-server.http-server.idle-thread.num.timestamp` corresponding to current `gravitino-server.http-server.idle-thread.num` metrics. what we expect may include timestamp to metric values, like...

[#6632] improvement(core): Add timestamp information to metrics

> seems we could close this PR? Why？

[#6632] improvement(core): Add timestamp information to metrics

> > > seems we could close this PR? > > > > > > Why？ > > Prometheus doesn't support timestamps in metrics. @Abyss-lord WDYT?

[Bug report] `trino-435-gravitino-0.7.0-incubating` failed to request gravitino-0.8.0-incubating

> Can I take this？ Are you working on this?

[Improvement] add error retry to TestFetchFileUtils

@FANNG1 Maybe you can close this. Because the related pull request is merged.

[Bug] Reading from hdfs file fails with writing hdfs file concurrent.

What's your solution?

[#2181]improvement(server): Replace ShuffleBlockInfo with ShufflePartitionedBlock in netty

Is this a improvement?