roryqi
> o.netty.util.internal.OutOfDirectMemoryError I read the code ``` package io.netty.util.internal; import java.nio.ByteBuffer; /** * {@link OutOfMemoryError} that is throws if {@link PlatformDependent#allocateDirectNoCleaner(int)} can not allocate * a new {@link ByteBuffer} due...
Maybe we should add some comments to explain this.
> Sorry, I write it wrongly. Below is the netty source code. If we set DIRECT_MEMORY_LIMIT to not a big number, will throw OutOfDirectMemoryError. But the jvm process will not...
Could you add some comments for this code?
CopyOnWriteArrayList is suitable case that read is more, write is less.
> Should we change the default value of `rss.server.hybrid.storage.fallback.strategy.class` to `RotateStorageManagerFallbackStrategy`? @zuston @jerqi @rickyma @smallzhongfeng > > https://github.com/apache/incubator-uniffle/blob/57f0f8bbcd530feb6ab1284c2eed0c08b9e2c9ae/server/src/main/java/org/apache/uniffle/server/storage/HybridStorageManager.java#L85-L88 I prefer not.
@zhengchenyu Could you add documents in an another pull request?
> > > However, if you want to move it to a independent project, I think you should sent a discuss thread to the dev mail list and go through...
> @rickyma @jerqi Does the client side support jdk11? We didn't test it. From the error, it seems that we don't use proper method to release memory for JDK11.
@rickyma Do you have any suggestion?