Jeroen Jacobs
Jeroen Jacobs
For the request it's indeed fine. It's for the following line: ```python episode = traverse_obj(video_data, ('playlists', ..., 'episodes', lambda _, v: v['pageInfo']['url'] == url), get_all=False) ``` I wanted to have...
As this issue is still present I'd reopen this GitHub issue.
@mmozuras I'd be happy to incorporate any feedback. :) Not very happy with passing it as an ENV variable but I saw no easy/clean way to do it otherwise.
> Let's try to think of alternatives before committing to passing values via ENV variables. This would require more refactoring, but maybe the whole `Config` class could be global, initialised...
Yes, I'm still planning on continuing to work on it but I had a lot on my plate the last few months which resulted in not enough time for this....
> Let's try to think of alternatives before committing to passing values via ENV variables. This would require more refactoring, but maybe the whole `Config` class could be global, initialised...
I didn't work on it anymore since then. I just (quickly) reread this. I think it would be best if @mmozuras or you gave feedback on the current implementation. Once...
Yeah, my idea was to contribute it as soon as I've got the time for it. 👍 😃
I haven't looked into this yet either. Since the GoPlay app now supports AirPlay I'm using that instead of downloading it first.
> Add back all deleted tests (even the ones from deleted extractors) @pukkandan what would be the point of this? I just had a look and all tests from deleted...