prontolabs
Adds a --config option to pass a path to a .pronto.yml config file
@mmozuras I'd be happy to incorporate any feedback. :)
Not very happy with passing it as an ENV variable but I saw no easy/clean way to do it otherwise.
Not very happy with passing it as an ENV variable but I saw no easy/clean way to do it otherwise.
Let's try to think of alternatives before committing to passing values via ENV variables. This would require more refactoring, but maybe the whole Config class could be global, initialised only once?
Let's try to think of alternatives before committing to passing values via ENV variables. This would require more refactoring, but maybe the whole
Configclass could be global, initialised only once?
I think that would make sese. :) 👍
What was the plan with this PR? Are we going to come up with a new approach or should this be closed for the time being?
Yes, I'm still planning on continuing to work on it but I had a lot on my plate the last few months which resulted in not enough time for this. I'm on holiday right now but I plan to pick this up again mid-August. Unless someone else picks in of course. :)
Let's try to think of alternatives before committing to passing values via ENV variables. This would require more refactoring, but maybe the whole
Configclass could be global, initialised only once?
@mmozuras I've made the Config a singleton object to make it global. There are still some pending tests but I've pushed the (working) code. Would you mind having a look at it already?
I didn't work on it anymore since then. I just (quickly) reread this. I think it would be best if @mmozuras or you gave feedback on the current implementation. Once we settle on an implementation I'll finish the tests so this can be merged. 👍
(I've been using this code in a fork since then actually.)
I'm closing this since #435 was merged, please reopen and fix merge conflicts if you still think this should be merged.
