Jerin Peter George

Results 40 comments of Jerin Peter George

I have tried the new changes in my local machine. Unfortunately, it's not uploaded to S3 ## Step to reproduce ### Part-1 1. Download the demo project and supporting files...

@GitRon I think we should initiate the S3 upload using [**`upload_file()`**](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.upload_file) method when we receive the last chunk from the client. But, if we try to upload the whole file...

Oops :persevere: Have you tried to reproduce the behavior that I [mentioned here](https://github.com/juliomalegria/django-chunked-upload/pull/39#issuecomment-566662502) ?? Anyway, let me ask you some doubt regarding this, that may help you to understand what...

Storing the chunks to a temporary location and moving it to the target location after completion is a good idea. I think we should implement this first before the S3...

Great! but this is only half of the solution. We should **move the `completed file` to `CHUNKED_UPLOAD_PATH`** when a user uses the default settings, shouldn't we? @GitRon

Sorry for the utter delay from my side. Thanks for your effort @GitRon and please do let me give a couple of days to recollect the project context ( :astonished:...

@GitRon Thanks for the PR. But, It is hard for me to review the PR since I have slipped away from the context, as I already said. Also, I don't...

I won't be able to do that :disappointed: You can contact @juliomalegria via his personal mail (`[email protected]` got from his personal site). If he didn't respond within a week, better...

@danielgarner64 You can close the opened file in **`on_completion`** method by overriding **`ChunkedUploadCompleteView`** as, from chunked_upload.views import ChunkedUploadCompleteView class MyUploadCompleteView(ChunkedUploadCompleteView): def on_completion(self, uploaded_file, request): uploaded_file.file.close() Apart from that, the method...

@danielgarner64 Is there any way I can *reproduce this error* ?