Jeremy Wootten

Results 1832 comments of Jeremy Wootten

@teamcons Still could not reproduce on OS7.1 or OS8 even after purging and reinstalling with `apt` to make sure I was running the released version. I do not have Tweaks...

Couldn't reproduce this recently by purging the `io.elementary.terminal` package and then reinstalling on OS8/Wayland. Maybe only occurs after a clean install?

Outstanding issue is a transparent gap between the tab bar and the header bar through which the desktop shows: ![Screenshot from 2024-06-21 10 33 00](https://github.com/elementary/terminal/assets/10513844/c8ae2913-e53a-46fe-bb2a-a6b0badf4e6d) This occurs on X and...

@danirabbit The problem seems to be due to the "terminal-window" styleclass previously applied to the grid containing the header and view. I have removed that class for now. I am...

@leolost2605 Yes, you are right - TerminalWidgets are not being destroyed when tabs are closed. I had similar issues a long time ago with Files widgets and ended up just...

@Marukesu This branch breaks some of the tests (although in reality it behaves OK). I have been unable to find out what is going wrong. It appears to be a...

@leolost2605 For now I have used disconnection of terminal widget signals before closing in order for them to be destroyed. If you have a more elegant way please let me...

@Marukesu Thanks for your helpful comments - I have tried to implement them. After those changes, the `action-quit` test was still not working (timing out) so I have have made...

@Marukesu Just noticed that the test pass in two of the builds but not in the development-target build. I have not idea why (It pass locally on OS8)

@Marukesu Is this OK to merge now, do you think?