Jeremy Ong

> This is most likely because we don't process the General Desktop usage page in general (which is what SYSTEM_SLEEP tries to use). See here: https://github.com/zmkfirmware/zmk/blob/main/app/src/hid_listener.c#L19 Currently, we only process...

https://tessil.github.io/robin-map/classtsl_1_1robin__map.html#a35021b11aabb61820236692a54b3a0f8

This should be higher priority. The project is extremely unfriendly to other projects that want to transitively include glslang. There's also `BUILD_TESTING` in the root cmake file.

Thanks for the PR! This code is very similar to the code for loading from a file. Can any of the code be consolidated or factored out in a more...

I was thinking something with less machinery. Really the only difference is a call to loadFile vs loadString, and the rest could be lifted to a separate common helper function...

I think removing all the uses of `this->` which isn't good idiomatic C++ and making things const correct (the status for example) should make this good to go.

That's a good question that I'm not sure I know the answer to. I know that some works/papers have clauses that prohibit rehosting, but I don't know if having a...

Yea I understand the error now. We can actually probably delete the line before that since it shouldn't accept arbitrary atoms. Accepting true and false should be sufficient.

Before I merge this, I just remembered that I never got around to implementing packed fields since it was a feature I didn't use haha.

Maybe I should leave this open until that happens?