Jeremy Meng

Results 160 comments of Jeremy Meng

the third parameter of `RestError` constructor is `statusCode`. We could pass xhr.response as the last parameter, after `request`. One concern is that the error response may contain sensitive information and...

@Czhang0727 thanks for reporting this issue! Could you please tell us how you are using ms-rest-js? as a direct dependency, or indirectly via other packages?

@Czhang0727 and do you have a link to the `SecurityTypeDomParser` mentioned above?

By adding stubs d.ts files. I no longer see "node" reference in our generated d.ts files, nor our api.md review file.

@Packmanager9 The current code assumes that `parent` is an object, but the error indicates that it could be a primitive type. Do you have some simplified repro? https://github.com/Azure/ms-rest-js/blob/386ed0ff198efe12a7caf59f6d1d34bedcbbd22d/lib/serviceClient.ts#L721-L731 The only...

@Packmanager9 could you please try wrapping the arguments to `listBySubscription` with an object? ```diff -client.workflows.listBySubscription(top, filter) +client.workflows.listBySubscription({top, filter}) ``` The method expects an options object ```ts listBySubscription(options?: Models.WorkflowsListBySubscriptionOptionalParams): Promise; ```

@Packmanager9 it's been a while, have you got a chance to look at the above suggestion?

We have a tripple-slash reference to "../dom-shim.d.ts" in msRest.ts and we pack this file at root folder of the package. The build output dir is `es/` but `es/lib/msRest.js` still keep...