Results 20 comments of Jeremy Kong

No objections to changing the API in the long term (in fact that's preferable, I remember this bit of defensiveness being somewhat annoying to add) - the main thing is...

Yeah, smoke testing in progress. Can add one or two for the wiring

`NamespacedConjureTimelockService` is probably not an interface we want to change right now.

This is fishy: ``` private List getTokenRanges() throws Exception { return getRandomGoodHost().runWithPooledResource(CassandraUtils.getDescribeRing(config)); } ```

I was OOTO from last week Friday. Will get to this at some point this week.

Gradle 7: @sudiksha27 is actually in the process of doing it!

I've been busy with planning and some team commitments, but will pick this up today or tomorrow. Apologies :(

Hmm yeah let me discuss this with some others in storage and get back to you on that (maybe @j-baker when he's back in?). I agree that your implementation seems...

The presence of these log lines continues in perpetuity (see 2020-02-17 11.12.00 screenshot on ticket). 30 seconds of bad logging would be acceptable for that, but I don't think that's...

Frustratingly if we want the exact behaviour of `split`, then counting the number of non-blank lines is not correct either (consider `a\n\nb`; split clearly returns 3 elements but there are...