Jeremy Cline

Results 100 comments of Jeremy Cline

The issue was that fixing it involved breaking an API in v2. I suppose a feature flag could be added, something like ``really_actually_do_verify`` which defaults to False but is documented...

The removal of ``cert_verify`` which is a public method. If you kept that and switched behavior based on a feature flag it'd probably be more palatable.

Oh, also, just to be clear I'm not a maintainer here, my feedback has no influence on the acceptance of such a pull request, is provided "as is", etc. :smile:

The way we've handled this in fedora-messaging is to register signal handlers. I'd recommend that approach. Handle the signal by setting a "stop" flag, and if that flag is already...

Hmm. I have a suspicion that this is a configuration/services problem of some kind. I tried both snippets and neither one worked for me. I'm going to label this as...

I definitely agree.

@reCursedd that sounds reasonable. Another option would be to add something in the ``endpoints`` config.

As far as I know it's still present. I don't think it's worth fixing at this point since we're probably going to stop using fedmsg.

@jwflory sure. And if anyone comes across this issue in the future, I'm happy to answer whatever questions you have. The user guide and API guide at https://fedora-messaging.readthedocs.io/en/stable/ is a...

We can probably fix this as part of #424