Severin Gehwolf

Results 387 comments of Severin Gehwolf

FWIW, it happens in JVM mode on `CTRL+C` as well with JDK 24.0.1 and a simple add-opens is not sufficient: ``` $ mandrel-java24-24.2.1.0-Final/bin/java --add-opens java.base/java.lang=ALL-UNNAMED -jar ./target/quarkus-app/quarkus-run.jar WARNING: A terminally...

Thanks. Does that mean this will only be fixed once quarkus picks up a new jboss threads version (provided the `--add-opens` is being added on the quarkus side)?

@dmlloyd OK. Could you please update here once that upgrade has been integrated into quarkus main? That would be much appreciated.

This is a patch that I've been playing with for getting the `--add-opens` added for quarkus. Seems to work for `quarkus-run.jar` and friends, but needs more work for quarkus tests:...

> Will this work for uberjar too? I think so, but I'll test. The issue I'm having is that quarkus tests (run by junit) need this too and I'm struggling...

> > Will this work for uberjar too? > > I think so, but I'll test. Seems to work fine for me.

Proposed the patch in https://github.com/quarkusio/quarkus/pull/47637 together with the `argLine` addition for tests.

> [@ia3andy](https://github.com/ia3andy) can you look at this? seems we need to have code generator add this explict add-opens + have quarkus update solve it for upgrades? @maxandersen @ia3andy I've created...

Closing for now and will let CI runs actually open it when there are issues.