Jesper Sørensen
Jesper Sørensen
@willcosgrove Here's what I did to solve a similar problem (adapted to your models): ```rb has_many :candidates do |serializer| # Set instance option for parent serializer, the option will be...
Hi @jeysal. Thank you for the quick feedback! After having tested the code with a manual mock, I'm not sure that there's a gap for close there. It appears to...
> Sorry if my message was not ideally structured, "Pro" and "Con" referred to the "what I've usually done" here Now I understand your feedback much better :smile: - thank...
This PR has been waiting for feedback for soon 3 years. I believe that the issue I was trying to solve is still in jest, I don't think this PR...
> our `reset`, `clear` and `restore` APIs already confuse people (including myself) I'm absolutely with you here. It's the one part of jest that I just can't get right 100%...
> It'd have to be async I guess, but other than that I think I like it! As you say it'd probably not work too well with multiple mocks, but...
@SimenB I've created a new PR for `withImplementation` https://github.com/facebook/jest/pull/13281 I'll close this PR as I believe `withImplementation` solves same issue as this PR, but (in most cases) in a better...
I believe all the feedback has been addressed now. Let me know if I need to do more.
@mrazauskas I believe there are no issues left. What is the next step from here?
I might be wrong but to me it seems that the failing job random and not related to the PR. If you agree with that assumption, can I get you...