Jan Petter Maehlen
Jan Petter Maehlen
After some initial tests and thinking, it seems like `cellpy` should use the `factory-pattern` for handling the different loaders. So - a more correct order of things would be: 1....
@Ozzstein might have some thoughts / input.
Sorry, @jayceslesar, I have no good ideas. I have not started looking into the database yet (it was @Ozzstein who worked with that feature). I hope to have some time...
@morrowrasmus, I agree that this would be an important feature for many cases. Maybe we should allow for choosing either 1) fully automatic, 2) user specifies what steps could be...
OK, - seems like I implemented a couple of "selectors" for `make_summary`: `def _select_without(self, exclude_types=None, exclude_steps=None, replace_nan=True)` Maybe this method can be helpful when implementing the additional CV-share column.
You are correct. And the main purpose of the `_select_without` method was to be able to perform statistics without including constant voltage steps. Don't remember why I included the "non-rest"...
> My current thinking is to split the CCCV-steps is to run the detection algorithm for every step. You mention that it could be good if the user could choose...
@morrowrasmus, I agree on all points :-) Make it reasonably simple for the first implementation, and then we can build upon that later when or if we have a robust...
@morrowrasmus; do you want to give it at try?
@morrowrasmus; if you could start on this, that would be great. I can check how changing the step-table influences loading older cellpy files (could potentially be some conflicts) and update...