Jeongseup

Results 8 comments of Jeongseup

Could you please review again? I modified as what you said.

I modified with your review. but, I don't fully understand the vetomint. so I'm not sure which place i called the check~ function is correct. and some check_invalid_~ functions is...

reference research for this issue https://github.com/tendermint/tendermint/blob/main/behaviour/doc.go https://github.com/informalsystems/tendermint-rs/blob/main/tendermint/src/evidence.rs#L23C9-L23C9 Evidence list to detect for violation report https://github.com/tendermint/spec/blob/d46cd7f573a2c6a2399fcab2cde981330aa63f37/spec/core/data_structures.md#evidence

Basically, I made this PR through [Glitch Hackerton BNB track](https://youtu.be/_U-ubzDDP4M?si=RtU88vepIyXTtYKH). I remembered [the track](https://x.com/GlitchHackathon/status/1637723690547937281?s=20) was creating S3 migration tools for BNB greenfiled chain. So, I created two PR for BNB...

Do you have a code style guide for PR? Please share a link or something for me

@tacole02 I did force-push for modifying what you said. and then I think we should modify again [this part](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/get-started/play-with-grafana-mimir/index.md#configure-your-first-alert-rule) for consistency. there should be changed to bolded text too

@tacole02 I'm late sorry, Could you check again finally for this PR?