Jens Tröger

Results 121 comments of Jens Tröger

No, because predicting text encoding from a given byte stream has always a degree of uncertainty (especially for small sample sets) — see also [Character set confusion](https://en.wikipedia.org/wiki/Extended_ASCII#Character_set_confusion).

@Woile a PR using the code above? If you think that’d be useful then yes.

@KyleKing actually… > I'm not sure if the change would work, but it might be good to add a test case for STDOUT like: `bytes([0x73, 0xe2, 0x80, 0x9d])`. That byte...

@gpongelli this issue isn’t really a bug and it’s not about emojis. The problem in this issue is about a sequence of bytes which contains UTF-8 encoded text, but the...

As per PR https://github.com/commitizen-tools/commitizen/issues/545 I rebased my branch. Do as you wish with this fix. ```diff diff --git a/commitizen/cmd.py b/commitizen/cmd.py index 7f4efb6..71fbe8f 100644 --- a/commitizen/cmd.py +++ b/commitizen/cmd.py @@ -3,6 +3,8...

@alvercau can you please reformat the output as [distinct code block](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code) using ` ``` ` instead of inlining? That traceback is very hard to read. However, judging from the last...

> @jenstroeger it does not end up in the commit message, it ends up in stderr, which is decoded by commitizen. Oh… running `cz commit` runs `git commit` which runs...

@alvercau [v2.29.6](https://github.com/commitizen-tools/commitizen/releases/tag/v2.29.6) just shipped with the fix.

Functionally nothing, testionally coverage 🤓

@Woile weekend I might have some time. Which one of the [tests](https://github.com/commitizen-tools/commitizen/tree/master/tests) do you suggest should host them—maybe [test_cli.py](https://github.com/commitizen-tools/commitizen/blob/master/tests/test_cli.py)?