Jens Tröger

Results 121 comments of Jens Tröger

Nope, just wanted to use the badge from [shields.io](https://shields.io/) because all other badges in the repo are generated there. Making the SLSA logo available as a Simple Icon slug would...

> Want to check for this inheritance and disable the error if that's found? We would need to clearly explain it in the documentation. Checking inheritance would make sense. In...

@dmntswntrs, I noticed the same in my own instance of editable. I’ve played around a bit and it looks like undo works for as long as you type new text...

@peyerluk, thanks! I previously used a simplistic approach that continuously snapshotted the content (similar to your [`extractContent()`](https://github.com/livingdocsIO/editable.js/blob/35e4e2a767db6351810a513bdcec4c69ee583057/src/content.js#L81-L94) function) of a [contenteditable](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable). That felt tedious, though, and I’ve never bothered to...

Oh, instead of returning the serialized HTML?

@marcbachmann this is what you meant, correct? If you’re ok with the change then I can open a PR. ```diff diff --git a/src/content.js b/src/content.js index 6039b8e..3f00065 100644 --- a/src/content.js +++...

I think working with a fragment is more in line with other code in this package (which works with fragments) and it avoids creating elements that have no other purpose...

> Is this inspired from some other tool where you can move elements this way? I'm not familiar with this combo. It’s not. I’m just looking for a comfortable way...

> It's merged now :) Great, thank you! Also, I just noticed that the `'move'` event is already added but doesn’t seem to be used anywhere? Is that a relic...

Lucky me, I’ve repurposed it for now 👍🏼