Jens Widell

Results 62 comments of Jens Widell

This should fix the problem: https://critic-review.org/334 I won't land it before I've added a test, which I doubt I'll get around to today, but you're of course welcome to try...

Yeah, there are known issues with that configuration. I would suggest using one of the others instead.

How do you think the case that the commit exists in multiple repositories should be handled?

IIRC it searches the repositories in some order, and uses the first, but I'm not sure it actually works. If there's a ?review=X query parameter, which there usually is, the...

Ouch, I'm very sorry you ran into those problems! I don't recognize the symptoms, but it I guess it might all be because of problems delivering mails. Mail delivery currently...

Critic's log files under /var/log/critic/main/ would be of some interest, in particular servicemanager.log, watchdog.log and maildelivery.log. If you still have them, it'd be great if you could email them to...

The intended workflow, or, if you like, workaround, in such a case is that you rebase the review first, then push the new commits to the review branch. I agree...

My experience is that I rewrite previous commit messages quite often. I usually don't mix history rewriting and rebasing onto a different (typically newer) upstream commit in the same rebase,...

The reason you can't mark changes as reviewed via the "move detection" view is essentially that it's not (necessarily) a complete view of the changes; if a file contains both...

Yes, the whole feature is rather under-documented. :-) (A news items was posted in Opera's internal system when it was originally added, explaining it to users there, but this of...