Jens Widell
Jens Widell
This sounds like a new feature in git that Critic needs to be taught to deal with. Did you by any chance upgrade to a new git version around the...
Critic needs fixing indeed. Thank you for reporting the issue! I will look into fixing it as soon as I can.
Looks very promising!
Looks awesomely!
@Tigge: There's a thread about front-end strategy on [email protected] that you might want to look at: https://list.critic-review.org/pipermail/critic-dev/2014-August/000075.html (continued in September; the archive system seems a bit stupid and doesn't track...
The reason it can take a little while for the dialog to appear is that I first check if the commented lines have already been modified by a later commit...
Some work on addressing this isuse: http://critic.whyi.org/r/11.
I would guess the fact that they're missing from the main review page is simply a caching issue. Have you tried force-reloading the page, or similar? (That's known to be...
Ah, cool. Thanks for investigating this! Having an email address is supposed to be optional, so the correct solution ought to be to fix the join.
Yes, this is an issue. You can usually always use the [reviewable], [relevant] or [full] filters to look at all changes in the review (filtered in different ways to only...