jensjoha

Startup `flutter` faster (cache git calls)

3

This PR makes `flutter` (as measured with `flutter test` directly in the `flutter` directory which has no `test` directory, thus just writing "there's no `test` directory) startup faster by caching...

This will fail (possibly the status entry in pkg/front_end/testcases/strong.status and/or pkg/front_end/testcases/weak.status has to be removed): ``` out/ReleaseX64/dart --enable-asserts pkg/front_end/test/fasta/weak_suite.dart -DsemiFuzz=true -- weak/macros/multiple_augment_class ``` or ``` out/ReleaseX64/dart --enable-asserts pkg/front_end/test/fasta/strong_suite.dart -DsemiFuzz=true --...

flutter.new (dartpad) "hello world" example only renders "Hello" when zoomed != 100%

1

When going to flutter.new and pressing the "run" button I get this:  My browser is zoomed to 110%. Zooming to 100% shows the whole "Hello, World!", but 90%, 80%,...

Can't catch error on `stdout.writeln`

5

I have this code ```dart import "dart:io"; void main() { try { stdout.writeln("Line #1"); stdout.writeln("Line #2"); stdout.writeln("Line #3"); stdout.writeln("Line #4"); stdout.writeln("Line #5"); } catch(e) { stderr.writeln("Error: $e"); } } ```...

SlowTypeTest is slow in JIT (related to Records it seems)

2

TL;DR: Replacing records with classes in a few maps reduces runtime with ~28% and makes `SlowTypeTest` go from taking ~22% of the time to basically taking nothing. This is only...

Dart VM `@pragma("vm:prefer-inline")` vs manually inlining

4

I've performed the following experiment on top of 7512050101f25530824db6200f4770ed8f083251. In https://dart-review.googlesource.com/c/sdk/+/349861/ I have the two versions I'm testing: * Patchset # 1 where I've manually inlined `declareMember` and `undeclareMember` into...

Say I have these 2 files: `main.dart`: ```dart import "lib.dart"; void main() { print(calculate()); } ``` and `lib.dart`: ```dart int calculate() { return 6 * 7; } int calculateSomethingElse() {...

```dart The formatter produced unexpected output. Input was: class A { A(int foo(int a)); } class B extends A { B.sub1(int super.bar1(int a1),); B.sub2(int super.bar2(int a2),); } main() {} ```...

Sorting named parameters and native

1

Commit 0defa95239024bf36b62f59d42130037cadfa519 introduced sorting of named parameters which apparently doesn't play well with native stuff. E.g. the test "co19/LibTest/core/Match/operator_subscript_A01_t01" fails because lib/regexp.cc (at about line 23) just takes in parameter...

This is different from library uri when working in parts, put also in patched libraries and in the future (possibly) in augment classes.