Jenn

Feature suggestion: burning features into DEM

3

Cool watershed delineation tool! I was wondering if you're planning to add tools to manipulate DEM in the future. I think it would be neat if you could burn culvert...

Deprecate swmm_lib_path in Simulation

3

Since updating pyswmm to use swmm-python, swmm_lib_path is not useful.

Remove duplicate enum subclasses from toolkitapi.py [swmm-toolkit/shared_enum.py]

1

Remove duplicate enum subclasses from https://github.com/OpenWaterAnalytics/pyswmm/blob/master/pyswmm/toolkitapi.py, where the enums are already defined in https://github.com/OpenWaterAnalytics/swmm-python/blob/dev/swmm-toolkit/src/swmm/toolkit/shared_enum.py

It would be awesome if edge and node in networkx contain data like node type (outfall, storage, junction etc) and edge contain data like link type (conduit, pump, etc).

The subcatchment runoff rate returned by the API endpoint is missing LID runoff rate. This issue is significant when LIDs cover the entire subcatchment. https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/6d6b5272250acaa3939db9e265f0e593dc96e43e/src/solver/toolkit.c#L2150-L2191 https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/025337c026dc2b6d493fb23ab05016329f7547cb/src/solver/output.c#L588 https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/develop/src/solver/subcatch.c#L866-L932 https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/025337c026dc2b6d493fb23ab05016329f7547cb/src/solver/subcatch.c#L894-L905