opentelemetry-plugin icon indicating copy to clipboard operation
opentelemetry-plugin copied to clipboard

Jenkins client spans don't honor `server.address` span attribute

Open cyrille-leclerc opened this issue 1 year ago • 1 comments

Jenkins and plugins versions report

latest jenkins otel plugin

What Operating System are you using (both controller, and any agents involved in the problem)?

any

Reproduction steps

Jenkins client spans don't honor server.address span attribute.

Git spans and probably other types of spans MUST use `server.addfress. See:

  • https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md
  • https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/rpc.md

See io.jenkins.plugins.opentelemetry.job.step.AbstractGitStepHandler

Expected Results

Compliant otel spans

Actual Results

server.address is missing, probably other attributes as well.

Anything else?

No response

cyrille-leclerc avatar Jun 13 '23 08:06 cyrille-leclerc

server.address is new an not yet supported by most O11y backends, adopting it now could break the visualization in many O11y backends.

cyrille-leclerc avatar Sep 20 '23 07:09 cyrille-leclerc

Fixed in:

  • https://github.com/jenkinsci/opentelemetry-plugin/releases/tag/3.1215.vc9db_a_0b_34c2a_

cyrille-leclerc avatar Jun 14 '24 10:06 cyrille-leclerc