Jake Meckley

> Some things could be organised better. I would suggest implementing whole component as sensor like how hx711 is implemented. > > I would personally make S300Component inherit from Sensor...

@DjordjeMandic I implemented the changes you requested. Most were fine but the setup function doesn't work for my local system: ```c++ void S300Component::setup() { const auto err = this->write(nullptr, 0);...

@DjordjeMandic I've done some more testing and figured out what my problem was. The test yaml file I used had the following i2c configuration: ``` i2c: sda: GPIO21 scl: GPIO22...

> That's definitely a bit strange, since the `scan` function should work the same way internally. I'm still not really sure why my sensor has a problem with the bus...

> Just mark sensor failed in setup if sending the command fails. I have the same non-acknowledgment issue when the I2C bus is scanned even with this code, so marking...

> Could be that i2c scan does not comply with weird 10ms delays requirement from datasheet between operations. That's a good point. You might've been right in your previous comment...