Jens Elkner

Results 112 comments of Jens Elkner

Build fail because CI tries to link against the wrong/buggy prometheus-client-c lib. See https://github.com/coturn/coturn/pull/1343/commits/121b31977b0316a0e7b53beed1ac2956bf0f4ff7

These tests are an absolute nightmare! They seem to be pretty bogus. Please advise, what's going wrong, what needs to be fixed.

Test bugs (home grown install wrt. libprom libs and includes and different clang-format versions depending on the distro in use) fixed.

Nobody there to review this PR? @KangLin , @eakraly , @misi ? It really helps to better understand coturn and get a feeling for it. E.g. the grafana dashboard I...

> Very good work! > > * Why use https://github.com/jelmd/libprom instead of dirt bikes > digitalocean/prometheus-client-c? Basically the [Readme](https://github.com/jelmd/libprom/blob/main/README.md) gives you a coarse overview. Also it exposes stringbuffer and simple...

> Thank you @jelmd for this monumental piece of work. Thanx @eakraly for your time and having a look at it! > But I do not think we can accept...

> @jelmd > > * prometheus-client-c is pre-distributed in most systems Really? Is any software actually using it? Didn't found any, when decided to fork (but obviously it was not...

> @jelmd About http server: > > * Use prometheus-client-c's built-in promhttp directly in the program. What do you mean. Plz name what you mean! You mean [promhttp_start_daemon()](https://github.com/jelmd/coturn/blob/%231340_better_metric_support/src/apps/relay/prom_server.c#L190) ? Otherwise...

> ## About HTTP servers. There are several solutions: Ehmm, 1st thing to note: libmicrohttpd as used in libprom is a http server (it even support https). It is not...