Josh Elliott

Results 17 comments of Josh Elliott

I was about to report this. Was #909 meant to fix it for FM signatures? We're still running into it now as well.

> hmm, well, from my point of view, its not really intended to be used that way. You will get differences, possibility for manual errors, and not a very good...

> 3. Rename `desc` parameter to `description` in `zcl_logger_factory=>create_log` and `open_log` Regarding this one, I agree with renaming it but why not something like `external_id`? Since ultimately that's what it...

Thanks for those instructions @d023604! I was able to get the plugin installed now on 2023-03, but still getting some errors like @RSegaux with the dependencies. I got mine down...

Completely agree with this, and it's the reason I have currently disabled this rule for us. It actually causes an error in abapOpenChecks for extra spaces as well. I am...

I slightly misspoke on my first comment, this is actually my preferred solution at the moment. Others might not agree, but it aligns with what I see in some other...

I favor the last example with fixed indentation with all extra spaces removed. I understand if others' don't, but an option for that would be nice.

I mentioned this same behavior as part of what I saw as a larger issue as # 3 [here](https://github.com/SAP/abap-cleaner/issues/73#issue-1789912657). That was in the context of different behavior between abap-cleaner and...

Might I ask why you would want to do this? It is actually the opposite of what is recommended in the [clean ABAP style guide](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#do-not-chain-up-front-declarations), which abap-cleaner is meant to...