Juan Carlos
Juan Carlos
Good point, let me keep label as deprecated and add labels.
@oceanjules I have updated the PR to keep `label` and mark it as deprecated and also adding `labels`. `label` is doing the same: store the adaptationSet label or the last...
@oceanjules @tonihei Hi! Do you have any more feedback about this PR?
> > What I'm trying to achieve is that a track with Director's commentary in English, for example, should contain a list of Labels with a description of the content...
Hi @tonihei, yeah, I'm not interested in `id` either for my use case, I just added it because it was in the ISO spec but what you say seems logic...
@tonihei by the way, `lang` is optional in `` per the ISO spec. So I don't think `localizedLabels` can be a Map using `lang` as a key. So maybe we...
This sounds good to me, I'll start working in the changes!
@tonihei working on this, I don't understand very well the `lllegalStateException` condition. After doing the first two points, we ensure that there will always be consistency if only one of...
@tonihei Correct, following the DASH manifest ISO, `label` shouldn't even exist. But currently it's implemented in Exoplayer because of a PR asking for it in 2018 (https://github.com/google/ExoPlayer/pull/4391). Maybe `` list...
@icbaker cool, I've added the `IllegalStateException` and some unit tests in `FormatTest`, so this should be ready for review.