Erin Genovy

Results 20 comments of Erin Genovy

Thank you both very much for the discussion and investigation on this! > If we're going the native route, we might as well use native Windows tools ([`copy`](https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/copy) instead of...

Thanks for making this PR and the JIRA ticket! Two quick questions: - Why are these defines not needed? If they aren't needed, then could they be removed rather than...

Thank you very much for filing a JIRA ticket, and for creating this PR! Regarding this: > This PR is not enough to fix [ICU-21554](https://unicode-org.atlassian.net/browse/ICU-21554), but it a step to...

Thank you very much for creating this PR, signing the CLA, and also for filing a ticket! :) To be honest, I'm not super familiar with MinGW and its conventions,...

Thank you for creating a PR! Would you be able to also create a bug/ticket for this change as well? https://unicode-org.atlassian.net/secure/Dashboard.jspa

Thanks for signing the CLA. Could you please file an issue at https://unicode-org.atlassian.net/ ? (All commits and PRs need to have a corresponding ticket). Thanks!

Thank you kindly for creating this PR, and also for filing a ticket! 🎉 It's sort of a nit, but the ICU project requires that commits be prefixed with the...

> Thanks for taking a look! You're welcome -- thanks for creating a pull-request! :) > I'll work through the problems and your comments, but I don't know when I'll...

It looks like the MSVC builds have the following warning with the change: ` d:\a\1\s\icu4c\source\i18n\number_decnum.h(20): warning C4910: 'icu_64::MaybeStackHeaderAndArray': '__declspec(dllexport)' and 'extern' are incompatible on an explicit instantiation (compiling source file...

When I previous tried removing the `dllexport` on the `MaybeStackHeaderAndArray` I ran into errors like this: `1>g:\c\icu4c\source\i18n\number_decnum.h(62): error C4251: 'icu_64::number::impl::DecNum::fData': class 'icu_64::MaybeStackHeaderAndArray' needs to have dll-interface to be used by...