jeffsmale90

Results 35 comments of jeffsmale90

I don't know if there's other cases where this is going to be problematic, but at least for `eth_getProof`, we can pass in `pending` block and throw an internal error:...

I have decided to close #3265 in favour of this approach. I still think there's an opportunity to improve the implementation, and to add validation, but I will open that...

> Hahaha @MicaiahReid maybe reviewers should run `npx prettier --write .` on `develop` themselves and then compare their changes to what is here (can be done via `git diff your-local-version...

This all looks fine - as an aside https://github.com/trufflesuite/ganache/blob/develop/CONTRIBUTING.md#pull-requests doesn't mention anything about PR title / description. Is that worth updating now / in the future?

For anyone looking, here's the documentation for the GH integration: https://github.com/Ezard/semantic-prs#readme

I've narrowed the scope of this PR as suggested by @davidmurdoch. It now _just_ stops processing requests, and rejects pending tasks. It makes a "best effort" attempt to resolve in...

I love a good dependency upgrade!

After attempting to resolve some of the short comings of this approach, I have decided to close the PR, and address this with a simpler fix. #3506 Initially I thought...