Jeffro
Jeffro
> True, but "expensive" here is lightning fast compared to process termination. I'd rather keep the diff minimal, unless you find that moving that test forward fixes some possible bug....
Removed one more class definition
@hyc Yes, sorry should've clarified "suggested". I definitely welcome discussion about why this is a bad idea or not.
rebased against master
@selsta done!
I'm also planning on adding a main page in a later commit
Looking through older PRs, I think this is a great idea, the only way I think it could be made better is if the program was also passed an argument...
A list of RPC error codes can be found here: https://github.com/monero-project/monero/blob/9750e1fa103539b3e533455500610aae76e253a5/src/rpc/core_rpc_server_error_codes.h#L34 error code -1 is returned for invalid parameters What do you mean by "or it has not been open"?
Here are my results: master real 63m45.448s user 60m5.132s sys 3m28.104s compil-epee-http-client real 61m43.451s user 58m18.784s sys 3m22.170s Specs: Ubuntu 20.04.4 LTS Dell XPS 15 9570 Intel Core i7-8750H 31...
Results from building 98e4e96: With `USE_UNITY=OFF`: real 49m37.932s user 47m25.331s sys 2m10.006s With `USE_UNITY=ON`: real 48m44.421s user 46m33.999s sys 2m8.321s What I did for each build: rm # all .o,...