monero icon indicating copy to clipboard operation
monero copied to clipboard

GCC: unused warnings

Open jeffro256 opened this issue 2 years ago • 3 comments

This PR fixes 4 instances of -Wunused...

jeffro256 avatar May 28 '22 18:05 jeffro256

At this point I'm unlikely to spend a lot of time thinking about it and fixing it well. So if people want to kill the warning, be my guest. I'd be better if people wanted to fix it properly instead of just killing the warning, but that's up to them.

moneromooo-monero avatar Jun 07 '22 19:06 moneromooo-monero

@jeffro256 Can you keep the refreshed variable untouched and only add the comment? We can keep the warning as a reminder for someone to look into, if it stays unfixed for another year then we can decide what to do next with it.

Sorry for this huge discussion :)

selsta avatar Jul 06 '22 02:07 selsta

@selsta done!

jeffro256 avatar Jul 12 '22 01:07 jeffro256