Jeffro

Results 188 comments of Jeffro

The reason I bring this up is because the functional tests fail with this commit as-is since the RPC wallet iterates through all subaddress indices less than `wallet2::get_num_subaddresses()` and returns...

I'm pretty sure the Debian build error is caused by this GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83258

This PR is an extension to https://github.com/monero-project/monero/pull/8704.

It replaces it, sorry for not being specific. It is a spiritual extension, but the implementation replaces what is in #8704. Specifically, #8704 uses a spendable vector as well, but...

Sorry, yeah that was why I originally PRed against your PR. This isn't really a patch to yours so much as it replaces the `pick_preferred_rct_inputs` commit. I figured since you...

You have closed your PR since then, do you still want to move forward with this one?

This may break the spirit of Polyseed's design choice to make seed phrases incompatible with other coins and features, but we could allow migrations to a Carrot key hierarchy seamlessly...

BTW line numbers are from monero submodule checked out at https://github.com/jeffro256/monero/commit/227970ee7d9bef4f1b305e94a8493c634dbe3ea0. It may by off-by-one in `api/wallet.cpp`.