Jeff Posnick
Jeff Posnick
I'm going to do a one-off run of an HTML analyzer on the minifier output before we merge this, just to get a gauge for how broken things might be.
Actually, this is using an older version of the HTML minifier. See https://github.com/GoogleChrome/web.dev/issues/8381
R: @bashi and @yutakahirano
Thank you, @aboba & co.! If you could follow the CLA steps outlined in https://github.com/GoogleChrome/samples/pull/752#issuecomment-966188534 I'll get this merged.
I don't think that providing a share image that is customized based on a hash or query parameter is going to be possible. It would likely server-side dynamic responses, and...
CC: @dotproto to confirm whether this is a documentation issue or something else.
CC: @vasilvv, who may know more about the certificate requirements for the sample.
The TOC will pin to the right when a media query that's keyed on the viewport `min-width: 992px` is met. Pinning the TOC to the left when the viewport is...
CC: @dotproto, as I believe @awfuchs is no longer working on Chrome Extensions.
In case it helps to look at [another implementation](https://github.com/GoogleChrome/sw-precache/blob/master/app-shell-demo/src/server.js), here's the server-side code I'm using in my demo to inline styles for a given URL during the initial render. It...