samples icon indicating copy to clipboard operation
samples copied to clipboard

Fix pipeThrough error and track API changes

Open aboba opened this issue 3 years ago • 4 comments

The current sample throws when attempting to send over a uni-directional stream.

aboba avatar Nov 05 '21 19:11 aboba

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 05 '21 19:11 google-cla[bot]

R: @bashi and @yutakahirano

jeffposnick avatar Nov 05 '21 21:11 jeffposnick

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 11 '21 10:11 google-cla[bot]

Thank you, @aboba & co.! If you could follow the CLA steps outlined in https://github.com/GoogleChrome/samples/pull/752#issuecomment-966188534 I'll get this merged.

jeffposnick avatar Nov 11 '21 20:11 jeffposnick