Jeff Posnick

Results 297 comments of Jeff Posnick
trafficstars

Thanks for raising this–we do have the default values in the JSDocs, from which our documentation is derived, but the JSDoc to HTML publishing flow that we're currently using ends...

CC: @tropicadri, the current Workbox lead.

I personally like using `injectManifest` mode for this sort of customization ([here's an example](https://github.com/jeffposnick/yt-playlist-notifier/blob/9c805c5da33f674ce3f187d30f5505616e6610d4/vite.config.ts) with `vite-plugin-pwa`), but if you wanted to do something similar using `generateSW`, you can with the...

Oh, yeah, I forgot that adding in a `message` event listener post-`install` would break, just like the other event listeners. I'll take that into account,

I did a quick prototype and it looks like adding in this functionality would take `workbox-core.prod.js` from 5513 to 5924 bytes. Given that `workbox-core` is always loaded, those extra bytes...

Moving over some thoughts from a separate conversation: if we had this module, it would be a good home for code that currently lives in `workbox-broadcast-cache-update`: https://github.com/GoogleChrome/workbox/blob/208850c1a670d0f7ec1b8647c0d7ce4319f9fa5d/packages/workbox-broadcast-cache-update/BroadcastCacheUpdate.mjs#L91-L127

`location.reload(true)` is meant to indicate that you want a hard-refresh: https://developer.mozilla.org/en-US/docs/Web/API/Location/reload Service workers are disabled during a hard refresh when triggered by `Shift` + Reload: https://developers.google.com/web/fundamentals/primers/service-workers/lifecycle#shift-reload I guess Chrome and...

Hello @cepm-nate! One thing that stands out is that you're calling the `workbox.broadcastUpdate.Plugin()` constructor with the wrong arguments. You're passing in a string as the first parameter, and an object...

Hello @PlopTheReal! I'm not sure what the right solution to this is, and I'll try to dig around a bit more to see if there's something triggered by Workbox's logic,...

Sorry about that! Okay, so let's take a step back and discuss two possible approaches: #### Easier: ensure that the service worker doesn't intercept your `.mp4` requests. Based on what...