Jeff Handley

Results 87 comments of Jeff Handley

> But for some reason, Copilot PRs don't seem to be getting this treatment... Oh, interesting. Copilot PRs do not have the required `pull-requests: write` permission, leaving the actions as...

@copilot Instead of a truncated Description column, update the PR description to provide a complete list of all fully-qualified APIs included in each of the Diagnostic ID Assignments. This is...

@stephentoub / @JeremyLikness / @jozkee / @ericstj / @MackinnonBuck - I recommend we break out experimental APIs up into granular diagnostics in this manner in preparation for moving some APIs...

@copilot There are build errors in Microsoft.AspNetCore.Diagnostics.Middleware because `ExperimentalAttribute` is found in 2 of its assembly references: > The type 'ExperimentalAttribute' exists in both 'Microsoft.Extensions.Telemetry, Version=10.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' and 'System.Runtime,...

@copilot Additional projects are failing for the ambiguous ExperimentalAttribute problem. It might be best to inject the attribute into all projects. But we can start with the next batch of...

@copilot Address [this comment](https://github.com/dotnet/extensions/pull/7116#issuecomment-3631674948)

@copilot The error is happening in more projects. We should probably just guard against it in all projects across the solution using the Directory.Build.props files. Example: > ##[error]artifacts\obj\Microsoft.Extensions.Diagnostics.Probes\Release\net9.0\Microsoft.Extensions.Diagnostics.Probes.AssemblyInfo.cs(13,44): error CS0436:...