Jeff Daily

Results 212 comments of Jeff Daily

Instead of uuid returning bytes, I switched it to explicitly return a std::vector which is interpreted as a list of ints. It will always be len 16.

@pytorchbot merge -f "unrelated macos failure; this PR is cuda/rocm only change"

Ouch, 2 reverts. Can any Meta folks help shepherd this one? The uuid attribute was added to hipDeviceProp_t in ROCm 6.0. This implies Meta isn't yet up to that version...

@malfet is there some #ifdef I could add that would remove this feature for your internal builds? I would like to land this but I don't know how to work...

> > @malfet is there some #ifdef I could add that would remove this feature for your internal builds? I would like to land this but I don't know how...

@malfet please double-check my use of FBCODE in https://github.com/pytorch/pytorch/pull/125083/commits/bd9edcaeffe0b771dc56e178f0da9d5e4b2a7154. Any chance we could double-check if this will break Meta-internal builds before landing again?

@malfet any progress landing this?

@malfet ping, any progress landing this?

> @jeffdaily do you think that new error reported is related? (it looks it does) I've looked at the failure log, and though I see the stack trace includes `at::cuda::blas::gemm_internal_cublas`...