Jeff Daily

Results 203 comments of Jeff Daily
trafficstars

@baijumeswani or @weixingzhang please merge. This is a one line change but it currently is blocking our internal build processes. Thank you.

@baijumeswani or @weixingzhang, another reminder. Thank you. @snnn are you able to merge? The dockerfile is trying to add a directory that does not exist.

Failures should have nothing to do with this change. Can we merge?

@baijumeswani or @weixingzhang or @snnn, another reminder to merge. Thank you.

I think this can be closed as of ROCm 2.7? https://github.com/ROCm-Developer-Tools/HIP/blob/854768787ee9bbd6ed22b3e8fd0f139955a57e6a/src/hip_module.cpp#L1015

The C function prints to stdout and that didn't seem correct to me to do from python. You weren't getting a python string back to manipulate on your own, or...

@mthrok please re-review. This PR is now up to date with latest main and the CMakeLists.txt has been improved.

> @jithunnair-amd > > Should we be concerned about ROCm build job failures?? > > `libtorchaudio.so: undefined symbol: __kmpc_fork_call` https://github.com/pytorch/audio/actions/runs/5539782179/jobs/10111098244?pr=2485 https://github.com/pytorch/audio/actions/runs/5539782179/jobs/10111098349?pr=2485 Yes, we need to fix those before we can...

> @jeffdaily @jithunnair-amd > > Seems like there was ROCm CI migration. Could you rebase or merge upstream? If possible, I would like to include this PR for the upcoming...