Jeff Carbonella

Results 13 comments of Jeff Carbonella

+1 :+1: I'm currently searching on a large table where the user chooses their own order, so the rank doesn't matter. I'm getting around this issue by clobbering the order...

The RBI for some of the other Rails gems (e.g. ActiveRecord: https://github.com/sorbet/sorbet-typed/tree/master/lib/activerecord) make use of version scoping so I think that would be appropriate to do here as well. Feel...

I can work on adding more tests and fixing the merge conflicts. Do you have thoughts on how to configure custom argument types (eg custom scalars)? We can just not...

> Not sure why there are build failures These are fixed 🙂 I had missed `gem("graphql", require: false)` in the additional gemfiles (e.g. `Gemfile-rails-6-1`), which meant that when we required...

I've run into a similar issue **(NOTE: Fix/workaround below)**. It appears both the custom `PM::TableViewCell` and the `UITableViewCellContent` default to 320x44, so any relative styles applied (e.g. `fr` or `fb`)...

The `.match()` matcher seems to actually just be a wrapper around [`.is()`](https://github.com/airbnb/enzyme/blob/master/docs/api/ShallowWrapper/is.md). I just submitted a PR to make it more consistent and support any valid [EnzymeSelector](https://github.com/airbnb/enzyme/blob/master/docs/api/selector.md) (see: https://github.com/producthunt/chai-enzyme/pull/121). Assuming...

Fixed via #968. @paracycle - I think this can be marked as resolved.

@froydnj - I think this is ready for a look. I rebased onto the latest master to pull in those specs that were backfilled locking in the weak/strong constructor behavior....

@froydnj - Pushed up a commit to address the object equality issue (and added a test case for it in sorbet-runtime to confirm). The issue was that for any string...

@froydnj - thanks again for the review! I pulled most of those test changes into those separate PRs that have already been merged to ensure we're locking in existing behavior....