Jeff Bolz

Format layout qualifiers on image function parameters?

16

Implementations are inconsistent about handling format layout qualifiers on image function parameters, and whether they are included in parameter matching. The GLSL spec seems to have a clear statement about...

Allow passing readonly SSBO members as "in" parameters

8

In https://github.com/KhronosGroup/glslang/issues/1870, glslang was changed to reject passing a readonly buffer member to a function if the formal parameter is not qualified as readonly. The spec language is: > Variables...

GL_EXT_subgroupuniform_qualifier and flow control rejoining

1

cc @sheredom Consider this example: ``` subgroupuniformEXT int x; if ((gl_InvocationID & 1) != 0) { x = 0 } else { x = 1 } use x; ``` Both...

vulkan: fix build for GGML_VULKAN_RUN_TESTS, add TFLOPS to logging

2

GGML_VULKAN_RUN_TESTS currently has build errors like: ``` ggml-vulkan.cpp(5251,5): error C2664: 'void ggml_vk_dispatch_pipeline(ggml_backend_vk_context *,vk_context &,vk_pipeline &,const std::initializer_list &,size_t,const void *,std::array)': cannot convert argument 4 from 'initializer list' to 'const std::initializer_list &'...

Compute derivative workgroup size error checks may raise false positives

1

> Thanks for merging. I just noticed that since this is doing the checks as it parses the shader, whether you get an error depends on the order of setting...