angular-svg-base icon indicating copy to clipboard operation
angular-svg-base copied to clipboard

Why doesn't this module support <use xlink:href="#path"></use> syntax?

Open everdimension opened this issue 9 years ago • 5 comments

I see in the description that this module purposefully handles only FuncIRI notation. Why is that? The following syntax is quite popular:

<svg>
    <use xlink:href="#path"></use>
</svg>

And it too suffers from the firefox/<base> bug.

Basically I had to implement my own directive which does exactly the same thing as your module, but for xlink:href attribute. Are there some valid reasons for not supporting it?

everdimension avatar Nov 10 '15 19:11 everdimension

@everdimension is your solution open source and/or available on The Internets?

mateatslc avatar Mar 31 '16 09:03 mateatslc

@mateatslc not right now, but I can publish it

everdimension avatar Mar 31 '16 12:03 everdimension

I would appreciate it ;)

mateatslc avatar Mar 31 '16 12:03 mateatslc

@mateatslc I've published the directive in npm and bower: https://github.com/everdimension/angular-svg-base-fix

If you have any issues let me know

everdimension avatar Mar 31 '16 15:03 everdimension

@everdimension Awesome, thank you! Created a PR to amend your README ;)

mateatslc avatar Mar 31 '16 21:03 mateatslc