jeff-zed

Results 17 comments of jeff-zed

@OhmSpectator Can you think of someone with performance testing experience and EVE who may be a resource for examining the best approach?

> [@jeff-zed](https://github.com/jeff-zed) I think [@kperakis-zededa](https://github.com/kperakis-zededa) could have ideas about what the VM for that test could look like. Additionally, as far as I can see, it should be implemented as...

@OhmSpectator Greetings. I have been reviewing the modules, but this is currently limited to pillar. Just for clarify: is this the scope?

> > [@OhmSpectator](https://github.com/OhmSpectator) Greetings. I have been reviewing the modules, but this is currently limited to pillar. Just for clarify: is this the scope? > > Yes, sir. I meant...

@OhmSpectator Thanks for your response. I understand the point about having filenames locally scoped. There are a number of filenames in `pkg/pillar/types/locationconsts.go`, but if I understand correctly, consistency for filename...

@OhmSpectator For each refactored module, I will put the files into separate commits for clarity, as well as the project documentation. What are your thoughts about "thorough testing"?

"if you are just changing documentation you don't need to worry about Eden tests, they are still running on GitHub public runners, so they are still unstable, sometimes we need...

> But in this case you're not only changing the documentation, you are changing code. I will create a PR and commit one module at a time. Testing for each...

@eriknordmark this will be a multi-commit PR, module by module.

@milan-zededa @christoph-zededa There is a minor opportunity to centralize the path `"/run/eve-hv-type"` https://github.com/lf-edge/eve/blob/7ab0c0b8b14650228e9ff3508a2606ba889fe8ab/pkg/pillar/base/kubevirt.go#L15-L16 https://github.com/lf-edge/eve/blob/7ab0c0b8b14650228e9ff3508a2606ba889fe8ab/pkg/pillar/hypervisor/hypervisor.go#L98 However, `pkg/pillar/types/dns.go` imports `pkg/pillar/base` for `pkg/pillar/base/logobjecttypes.go` https://github.com/lf-edge/eve/blob/7ab0c0b8b14650228e9ff3508a2606ba889fe8ab/pkg/pillar/types/dns.go#L15 Because `pkg/pillar/base` is used in so many modules (not...