Justin Edwins
Justin Edwins
There is one TODO left for an additional test I would like to add and I still need to implement Webhook validation for OnJobFailureReasons. Besides that, I consider the code...
> Can we move all the helpers in jobset_controller.go specific to failure policies to a failure_policy.go file, and add unit tests for any important ones in failure_policy_test.go? Same as success_policy.go...
> Can we move all the helpers in jobset_controller.go specific to failure policies to a failure_policy.go file, and add unit tests for any important ones in failure_policy_test.go? Same as success_policy.go...
> pls don't amend the commits, it makes it hard to review because we can't tell the diff @ahg-g, there is a "Compare" button next to each amended commit to...
> > > pls don't amend the commits, it makes it hard to review because we can't tell the diff > > > > > > @ahg-g, there is a...
@prashantrewar the issue is still open as far as I am aware. Feel free to claim it.
/assign
/assign
Upstream K8s test docs that use containers https://github.com/kubernetes/kubernetes/blob/ec301a5cc76f48cdadc77bcfbd686cf40b124ecf/build/README.md
@chansuke are you still working on this? I will assign it to myself if not.