Jed
Jed
Kudos to the development of this project. The package looks super promising! There are [some concerns about lack of maintenance/use](https://github.com/facebook/create-react-app/issues/5677#issuecomment-435489198) that might be alleviated from some good tests written against...
https://github.com/callstack/linaria/issues/364#issuecomment-634052603
Redux-thunk has [a feature where you can inject a custom argument](https://github.com/reduxjs/redux-thunk#injecting-a-custom-argument). I think this library can support the same feature if it were implemented like so: ### helpers/useThunkReducer.js ```js import...
Fix #59
Be great if the `complete` command accepted a `string[]`. Ultimately, I want to do this: ```json { "complete": [ "cd {{ name or org }}", "git init", "npm install", "git...
Error is thrown here when the `rule` is `undefined`: https://github.com/postcss/postcss-custom-properties/blob/a250907b9ca0b336d6c0ca948a1db2fe2d145309/src/lib/is-ignored.js#L5 Fix should probably be implemented here to check if the rule exists before sending it to `isBlockIgnored`. https://github.com/postcss/postcss-custom-properties/blob/a250907b9ca0b336d6c0ca948a1db2fe2d145309/src/lib/is-ignored.js#L11
## 10 tests (on master) currently fail **_only_** on Windows - [glob:brackets_close_inside](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/glob/CMakeLists.txt#L60) - [glob:brackets_nclose_inside](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/glob/CMakeLists.txt#L66) - [glob:braces_escaped_comma1](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/glob/CMakeLists.txt#L161) - [glob:braces_escaped_brace1](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/glob/CMakeLists.txt#L166) - [glob:braces_escaped_brace2](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/glob/CMakeLists.txt#L167) - [glob:braces_escaped_brace3](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/glob/CMakeLists.txt#L168) - [parser:escaped_semicolon_in_section](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/parser/CMakeLists.txt#L119-L120) - [parser:escaped_octothorpe_in_section](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/parser/CMakeLists.txt#L147-L148) - [filetree:windows_separator](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/filetree/CMakeLists.txt#L73) - [filetree:windows_separator2](https://github.com/editorconfig/editorconfig-core-test/blob/09e6038095db39e6cdc3ae822e8338e39294d032/filetree/CMakeLists.txt#L76)...
By using the [async version of glob](https://npmjs.org/package/glob) and providing a calling a callback method.
In reference to https://github.com/editorconfig/editorconfig/issues/83