Justin Chadwell
Justin Chadwell
No worries, thanks @DYefimov! Will continue the conversation over there :smile: No worries about the tests, that's what CI is for :tada:
URLs shouldn't be the determining factor here I don't think - the complexity comes with `tar`s/`git`s/etc. For a `tar`, I'd expect that it behave *exactly* like a directory, so with...
:wave: @DYefimov just wanted to follow up and check to see you weren't blocked on anything?
Looks like the test suite is running the right way, that's how I run individual tests. I also just tried a test using `TestServer`, `TestHTTPDockerfile`, which seems to run perfectly...
I tend to not worry too much about the state of the git history while I'm working in "draft mode" - at least while the code's final shape is unclear,...
Have left a couple comments, when you're happy with the state of this, I think it's good to come out of draft :tada: 1. Yup, `ADD`ing individual files isn't supported,...
@DYefimov all good? Just wanted to checkup to see if there's anything else or other clarification you need?
> What about the documentation? Guess it should be placed right after this one: https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#copy---link Do you want me to write a skeleton for it? :eyes: that would be wonderful...
> One thing confused me a bit in the documentation: ADD says This flag defaults to false for the --keep-git-dir flag. What does it mean exactly "defaults" - like if...
> Can you, please, help with the CI pipeline for the coverage. Am I missing some important step to pass the rest of the checks? It looks like `TestDockerfileAddArchiveWildcard` fails...