Jed Schmidt
Jed Schmidt
i don't see any issues. @aslakhellesoy, does this look okay to you?
i'm not really familiar with Sails, unfortunately. not sure i can help here... have you asked folks from that community?
looks good to me. @aslakhellesoy, any thoughts?
to be honest, i'm a bit far from the original code to be very helpful, but could give feedback if there is code to see.
Actually, this isn't a typo. You can use either library.
Ah, my bad. I misread. Thanks, @troyk!
@jason-klein, would you mind submitting a PR with this fix?
@joshribakoff, this is basically what i'm thinking, though my experience in the domain is pretty shallow. not a fan of hardcoding and would like this to work on environments that...
hey @benthepoet, can you update the test to cover your issue? tests run fine for me on v4.4.5,
cool. can you tee up a PR with the change you need?