Jean Barkhuysen

http2_client is missing tests

16

The following cases are untested, and should be tested: - https://github.com/grpc/grpc-go/blob/fb6867e42b4743663f07f4c7ce6c29c8d01247e1/internal/transport/http2_client.go#L275-L278 - https://github.com/grpc/grpc-go/blob/fb6867e42b4743663f07f4c7ce6c29c8d01247e1/internal/transport/http2_client.go#L279-L282 - https://github.com/grpc/grpc-go/blob/fb6867e42b4743663f07f4c7ce6c29c8d01247e1/internal/transport/http2_client.go#L298-L301 - https://github.com/grpc/grpc-go/blob/fb6867e42b4743663f07f4c7ce6c29c8d01247e1/internal/transport/http2_client.go#L304-L307 e.g. changes in https://github.com/grpc/grpc-go/pull/2219 were almost merged that should not have because of...

I took a stab at better documenting some things in syntax.go, which I've struggled to parse from godoc alone. I probably got some things slightly (or very) wrong - let...

For the sake of semantics and (minimally) lowered barriers to entry.

Popover with no children

6

This does not work: ``` ``` This does: ``` ``` It'd be nice if both worked =)

ClientCompletedRPCsView does not have meaningful groupings

2

In my code I have, ``` // Subscribe views to see stats in Stackdriver Monitoring. if err := view.Register( ocgrpc.ClientSentBytesPerRPCView, ocgrpc.ClientReceivedBytesPerRPCView, ocgrpc.ClientRoundtripLatencyView, ocgrpc.ClientCompletedRPCsView, ocgrpc.ClientSentMessagesPerRPCView, ocgrpc.ClientReceivedMessagesPerRPCView, ocgrpc.ClientServerLatencyView, pubsub.AckCountView, pubsub.ModAckCountView, pubsub.NackCountView, pubsub.PullCountView,...

I noticed that when I leave my app running for a period of time, eventually it stops reporting with this error: ``` { insertId: "i1qjvug3b9hn98" labels: {…} logName: "projects/deklerk-sandbox/logs/go-ps-consumer" receiveTimestamp:...

Failures go waaaaay off screen to the right

Jsx renderer uses rouge jsx lexer (from 2.0.6 onwards)

1

Signed-off-by: Tom Chen See: https://github.com/jneen/rouge/issues/275

Feature request: How are two people related?

2

Thank you for your work on this project. It has been invaluable in helping me learn my wife's huge indian family, and they love seeing it too. ---------------------- Given two...