Jean-Baptiste Martin

I don't understand why you are overriding window functions in _init method, instead of creating and exposing wrappers on those. It's a potential disaster for libraries that use them. e.g....

fix: fix stdio and tons of windows issues

3

This PR adds back stdio for output priting and the `shell: true` to spawn method so it can properly run on Windows. This was broken in https://github.com/serverless/serverless-python-requirements/commit/937fa564bf12fcb043678a0b48064bc60cbd2ea2

feat: allow a custom out dir from forge config

1

- [X] I have read the [contribution documentation](https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md) for this project. - [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate. - [ ]...

Rebuilding frida bindings

5

@oleavr I've developed a one-liner to get the proper binaries since it could be a bit tedious to manually find the frida dependency, delete it and set the environment variables:...

RequestQueue metrics don't get updated

1

**Describe the bug** RequestQueue metrics aren't updated after calling addRequest. I've noticed most methods get the queue through `findRequestQueueByPossibleId` while `toRequestQueueInfo` works with `this` so it might actually be using...

Dependency flagging is wrong when importing files from external dependencies

1

The following gets flagged as unresolved: ``` 1 │ @comp/interop/lib/interop/pub/flow/index.mjs 2 │ @comp/interop/lib/interop/pub/io/index.mjs 3 │ @comp/interop/lib/interop/priv/s3/putObject/index.mjs ``` While the lib gets flagged as unused: ``` 1 │ @comp/interop ``` It...

Archive Shipit?

6

@gregberge Shipit was very useful at one time, but better and easier approaches exist today, such as Github workflows. The repo should probably be archived, with links to modern alternatives...

on_error callback stops being called after first reconnection

1

After a failure, this line will set the WebSocketApp instance in reconnecting mode forever: https://github.com/websocket-client/websocket-client/blob/master/websocket/_app.py#L613 Indeed, `setSock` will only be called as reconnecting. As a result any further error will...

Automatic reconnection docs misleading

1

README says: ``` Most real-world WebSockets situations involve longer-lived connections. The WebSocketApp run_forever loop will automatically try to reconnect to an open WebSocket connection when a network connection is lost...