John Duff

Results 8 comments of John Duff

Our main concern was that adding another API call on every request for rates would slow down the overall request too much. That being said, I think this would be...

Awesome, we're already thinking along the same lines :). Looking forward to seeing some pull requests, and good luck with that migration!

If state is not actually needed for the rate requests I would prefer to just leave it out. Including it is just another piece of data that could potentially be...

If you add a call to the translate method that looks something like this: I18n.t('activerecord.errors.messages.record_invalid', :errors => errors) The rake task fails. This could be a bit of an edge...

Doing that in the console and then running the rake task will do nothing since the task parses the application files to look for those calls. Drop that call into...

Can you give a few examples of the test cases you would make pass with this change? I can't think of the cases where you would have `an` instead of...

I forgot about fractions lol. If you want to submit a PR for this I'll take a look, thanks!

If it doesn't complicate the codebase too much I would be happy to accept a PR for this.