Sheng Chen

Results 356 comments of Sheng Chen

@Eskibear Thanks for sharing the context. I'll propose a more general one later.

@rgrunber @Eskibear I have some new thoughts of the proposal: Basically, I'd like to simplify the contribution point to only two methods: ```java interface CompletionRankingProvider { void rank(List proposals, CompletionContext...

@rgrunber @Eskibear I update the proposal. Please take a look when you have time. 😃 No need to include it in next release. But we can do some implementation verification...

This PR is part of https://github.com/eclipse/eclipse.jdt.ls/issues/2011. ### Background As mentioned in https://github.com/eclipse/eclipse.jdt.ls/issues/2011, when a constructor declaration does not have its parameter names information in its index, JDT needs to take...

(Just back from vacation) Yes, considering the upstream discussion about [the shared index](https://github.com/eclipse-jdt/eclipse.jdt.core/issues/110) is still under going. Even the concept is accepted, it still take several months to be available....

The PR is updated. Since in LSP spec, it says: All other properties (usually `sortText`, `filterText`, `insertText` and `textEdit`) must be provided in the [textDocument/completion](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_completion) response and must not be...

I think it's not supported yet. Is that true? @Eskibear

Looks like in both Eclipse and IntelliJ will only add parentheses when the parameter number is larger than 1. And I didn't find a setting to control that behavior. (Correct...

Using IWorkspace#run() to wrap the semantic token calculation looks good to me. As long as the scheduling rule set to that URI, the semantic token calculation should be mutually exclusive...